feat: wire up file sync window#64
Merged
Merged
Conversation
spikecurtis
reviewed
Apr 1, 2025
spikecurtis
approved these changes
Apr 2, 2025
| Ssh, | ||
| } | ||
|
|
||
| public class CreateSyncSessionRequestEndpoint |
Collaborator
There was a problem hiding this comment.
Just wondering out loud: these names are getting really long... is it C# style to namespace them rather than have a long prefix?
Member
Author
There was a problem hiding this comment.
I'm not sure what the convention is. Another option would be to move these inside the "parent type" e.g. new CreateSyncSessionRequest.Endpoint().
Collaborator
There was a problem hiding this comment.
That makes sense to me since they are only used to fully define the CreateSyncSessionRequest type
Member
Author
There was a problem hiding this comment.
Renamed these to:
CreateSyncSessionRequest.EndpointCreateSyncSessionRequest.Endpoint.ProtocolKind(can't beProtocolor it conflicts with the property with the same name)
So the names are longer when using them, but they're segregated and not cluttering up the main namespace
spikecurtis
approved these changes
Apr 2, 2025
- Use locks during operations for daemon process consistency - Use a state model for UI rendering - Use events to signal state changes - Fix some tooltip problems that arise from polling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PauseSyncSessionandResumeSyncSessionSyncSessionViewModelthat wrapsSyncSessionModeland adds view methods (as you cannot access the parent context if you're in aItemsRepeaterapparently)TODO:
Closes #26
Closes #28
Closes #29